docs: small multiples can split by two dimensions - #11523
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Claude finished @igorlukanin's task in 1m 12s —— View job Docs review — 0 high, 2 medium, 2 lowDocs-only change; the second-axis story reads well and the 5 × 5 correction is applied consistently. Two internal contradictions worth fixing before merge (both posted inline), plus two nits below. Full review
Medium1. 2. Low3. 4. Legacy duplicate not touched — correct, but worth confirming intent. Verified fine
One process note from the PR body: since this also carries the 5 × 5 correction from #11498, whichever lands second will conflict on lines 28 and 43. |
6cd3890 to
7536a92
Compare
|
Claude finished @igorlukanin's task in 58s —— View job Docs review (updated) — 0 high, 0 medium, 3 lowBoth of my earlier threads are now resolved — the "single row of panels" wording and the Grid cell were both fixed as suggested, and the author went further by clarifying Sort panels by for two dimensions. The page now reads consistently on the main story. Three low nits remain, two posted inline. Full review
Low1. 2. 3. Frontmatter Verified fine
Unverifiable from the repo
Still true from the earlier review: this carries the 5 × 5 correction from #11498, so whichever lands second will conflict on lines 28 and 43. |
7536a92 to
f0e2cae
Compare
|
Claude finished @igorlukanin's task in 49s —— View job Docs review (3rd pass) — 0 high, 0 medium, 2 lowBoth suggestions from the last pass were applied verbatim (Sort order caveat at line 31, per-axis overflow framing at line 47), and all four of my earlier threads are resolved. The page now tells one consistent story across lines 18, 28, 30–31, 45, 47, 49, and 61. Two small gaps remain, one posted inline. Full review
Low1. 2. Frontmatter Verified fine
Unverifiable from the repo
Still true from earlier passes: this carries the 5 × 5 correction from #11498, so whichever lands second will conflict on lines 28 and 43. |
|
Low 1 and 2 are in. Left the frontmatter description alone: one panel per dimension value is still the shape a reader arriving from search is looking for, and the grid is the second sentence of the page rather than the summary. |
f0e2cae to
befcda5
Compare
|
Claude finished @igorlukanin's task in 53s —— View job Docs review (4th pass) — 0 high, 0 medium, 1 lowThe new line 16 covers the round trip back to a single plot and all five earlier threads are resolved. One small gap left, posted inline; nothing blocking. Full review
Low1. Not re-raising the frontmatter Verified fine
Unverifiable from the repo
Still true from earlier passes: this carries the 5 × 5 correction from #11498, so whichever lands second will conflict on lines 28 and 43. |
befcda5 to
bb717b1
Compare
|
Claude finished @igorlukanin's task in 40s —— View job Docs review (5th pass) — 0 high, 0 medium, 0 low · looks readyThe new clause on line 18 ("Only this picker has a cross: the first one is switched off with the toggle rather than cleared") closes the last open gap, and all six of my earlier threads are resolved. I have nothing new to raise. Full review
Verified fine
Unverifiable from the repo
Still true from earlier passes: this carries the 5 × 5 correction from #11498, so whichever lands second will conflict on lines 28 and 43. |
Small multiples can now split a chart by two dimensions — one across the columns and one down the rows — so the page's "One split dimension" limitation no longer holds.
This also carries the 5 × 5 grid maximum correction from #11498, so the two agree wherever they overlap. Depends on the UI change shipping first.